Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTT-421: Added warning when events.enabled=true #257

Merged
merged 15 commits into from
Feb 17, 2022
Merged

OTT-421: Added warning when events.enabled=true #257

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
439ac29
OTT-421: Unit tests and basic framework for events consumption and va…
pm-shriprasad-marathe Jan 31, 2022
6f4e60a
Merge branch 'I1725_vast_event_trackers' into OTT-421_host_level_config
pm-shriprasad-marathe Jan 31, 2022
80d574c
OTT-421: Reverted unwanted change.
pm-shriprasad-marathe Jan 31, 2022
96e2096
OTT-421: Changed eventvalidation interface according to configuration…
pm-shriprasad-marathe Jan 31, 2022
8b194ec
OTT-421: Reverted unwanted change
pm-shriprasad-marathe Jan 31, 2022
c96abdf
OTT-421: Made validate method from eventvalidation.go private
pm-shriprasad-marathe Jan 31, 2022
a8fc590
OTT-421: Added note to not enabled this feature. Because, it is still…
pm-shriprasad-marathe Feb 3, 2022
59b36e0
Merge branch 'I1725_vast_event_trackers' into OTT-421_host_level_config
ShriprasadM Feb 3, 2022
4124091
OTT-421: Temporary print statement
pm-shriprasad-marathe Feb 8, 2022
1bce441
Merge branch 'I1725_vast_event_trackers' into OTT-421_host_level_config
pm-shriprasad-marathe Feb 15, 2022
0b5a826
OTT-421: Addressed code review comments
pm-shriprasad-marathe Feb 15, 2022
c274f3f
OTT-421: Fixed test failures
pm-shriprasad-marathe Feb 15, 2022
15dbc22
Merge branch 'I1725_vast_event_trackers' into OTT-421_host_level_config
pm-shriprasad-marathe Feb 15, 2022
3d1ec42
Merge branch 'I1725_vast_event_trackers' into OTT-421_host_level_config
pm-shriprasad-marathe Feb 15, 2022
a50cdd3
OTT-421: Added warning when events.enabled is true
pm-shriprasad-marathe Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/eventvalidation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"strings"

validator "github.com/asaskevich/govalidator"
"github.com/golang/glog"
)

// VASTEventElement indicates valid VAST event element
Expand Down Expand Up @@ -51,6 +52,7 @@ var trackingEventTypeMap = map[TrackingEventType]struct{}{
// validate verifies the events object and returns error if at least one is invalid.
func (e Events) validate(errs []error) []error {
if e.Enabled { // validate only if events are enabled
glog.Warning(`Don't enable this feature. It is still under developmment - https://github.com/prebid/prebid-server/issues/1725`)
if !isValidURL(e.DefaultURL) {
return append(errs, errors.New("Invalid events.default_url"))
}
Expand Down