You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was just using chi_check and noticed it returns "Too few characters" for the empty string "", whilst this is technically correct (the string has 0 characters), it's not what I would have expected. I would have expected it to return "Missing" as it does for NA.
library(phsmethods)
chi_check(c("", NA))
[1] "Too few characters" "Missing"
It would be simple to change this and I'd be happy to do a PR, if others agree with the change?
The text was updated successfully, but these errors were encountered:
Spoke to Tina on teams and I'll do a PR to change this so that we have 2 categories 'Missing (NA)' and 'Missing (Blank)'. 'Missing (NA)' will be the current 'Missing' and 'Missing (Blank)' will be for the empty string ""
I was just using
chi_check
and noticed it returns"Too few characters"
for the empty string""
, whilst this is technically correct (the string has 0 characters), it's not what I would have expected. I would have expected it to return"Missing"
as it does forNA
.[1] "Too few characters" "Missing"
It would be simple to change this and I'd be happy to do a PR, if others agree with the change?
The text was updated successfully, but these errors were encountered: