Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI check return values #76

Closed
Moohan opened this issue Apr 1, 2022 · 2 comments · Fixed by #78
Closed

CHI check return values #76

Moohan opened this issue Apr 1, 2022 · 2 comments · Fixed by #78
Assignees

Comments

@Moohan
Copy link
Member

Moohan commented Apr 1, 2022

I was just using chi_check and noticed it returns "Too few characters" for the empty string "", whilst this is technically correct (the string has 0 characters), it's not what I would have expected. I would have expected it to return "Missing" as it does for NA.

library(phsmethods)

chi_check(c("", NA))

[1] "Too few characters" "Missing"

It would be simple to change this and I'd be happy to do a PR, if others agree with the change?

@Tina815
Copy link
Contributor

Tina815 commented Apr 8, 2022

I would leave it as I think "too few characters" is enough to remind users what happened.

@Tina815 Tina815 closed this as completed Apr 8, 2022
@Moohan
Copy link
Member Author

Moohan commented Apr 8, 2022

Spoke to Tina on teams and I'll do a PR to change this so that we have 2 categories 'Missing (NA)' and 'Missing (Blank)'. 'Missing (NA)' will be the current 'Missing' and 'Missing (Blank)' will be for the empty string ""

@Moohan Moohan reopened this Apr 8, 2022
Moohan added a commit that referenced this issue Apr 8, 2022
@Moohan Moohan linked a pull request Apr 8, 2022 that will close this issue
@Tina815 Tina815 closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants