[WIP] C# 8 nullable reference type support #99
Conversation
| @@ -9,8 +9,11 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PublicApiGenerator", "Publi | |||
| EndProject | |||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{52361C5B-F247-42C5-8455-BD1DEDB5C903}" | |||
| ProjectSection(SolutionItems) = preProject | |||
| ..\appveyor.yml = ..\appveyor.yml | |||
| ..\build.ps1 = ..\build.ps1 | |||
| ..\.gitattributes = ..\.gitattributes | |||
There was a problem hiding this comment.
Thanks for cleaning this up
| @@ -250,7 +250,7 @@ public static void Main(string[] args) | |||
| var asm = Assembly.LoadFile(fullPath); | |||
| File.WriteAllText(outputPath, ApiGenerator.GeneratePublicApi(asm)); | |||
| var destinationFilePath = Path.Combine(outputDirectory, Path.GetFileName(outputPath)); | |||
| if(File.Exists(destinationFilePath)) | |||
| if (File.Exists(destinationFilePath)) | |||
There was a problem hiding this comment.
Not really related but I'm ok with the change. I'll probably align code styles anyway after merging
| var typeName = GetTypeNameCore(type, nullabilityMap, nullable); | ||
|
|
||
| if (nullable) | ||
| typeName = CSharpAlias.Get(typeName) + "?"; |
There was a problem hiding this comment.
Kudos to keep it consistent with the other string concatenations and not use interpolation yet.
sungam3r
changed the title
|
Need more tests for generic constraints and base classes. |
| }"); | ||
| } | ||
|
|
||
| [Fact(Skip = "There is a problem with these tests - the attribute says 1 instead of 2")] |
There was a problem hiding this comment.
I pinged Immo over twitter. Maybe he has some input
There was a problem hiding this comment.
In fact, we found a place where these attributes are stored. And it seems that they are hard to get.
|
CI build on Windows should be fixed. Maybe rebase on top of master? |
|
Can this be done from the web interface? |
|
Sorry that I was assuming you know how to rebase. Usually I rebase in Gitextensions or the command line. You can only do it on Github when you merge the PR |
fixes #54
tests for NRT