Style map message and add zoom functionality #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrankl
reviewed
Sep 14, 2020
| <Box | ||
| sx={style.message} | ||
| as="button" | ||
| onClick={() => (map !== undefined ? map.zoomTo(maxZoom) : null)} |
There was a problem hiding this comment.
Nice, this works great. You might want to consider using a && operator instead of the ternary operator because there is no "else" aspect of this condition.
|
Hey @alexelash this looks great. One thing I noticed, which wasn't captured in this issue, is that this component isn't actually horizontally centered. Would you be able to horizontally center it before merging? |
alexelash
force-pushed
the
feature/al/style-map-message
branch
from
54fddee
to
89c1ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR styles the "zoom in to work with blocks" message to pop more against its background. It also turns it into a button so that a user can quickly get to the correct zoom level to work with blocks.
Checklist
CHANGELOG.mdand grouped with similar changes, if possibleDemo
Notes
N/A
Testing Instructions
git pullCloses #372