Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "Saved" after accepting changes #431

Closed
tgilcrest opened this issue Sep 17, 2020 · 0 comments · Fixed by #439
Closed

Display "Saved" after accepting changes #431

tgilcrest opened this issue Sep 17, 2020 · 0 comments · Fixed by #439
Assignees
Labels

Comments

@tgilcrest
Copy link

It would help users to give an indication that their changes are saved after accepting. A possible implementation that could work is to show "Saved" after the spinner disappears on a successful PATCH request.

After hitting Accept, see the spinner:
image.png

After the request completes successfully, see "Saved", something like this:
image.png

When a new selection is made, remove Saved and show Accept/Cancel:
image.png

Unclear what should happens if the user hits cancel. Could see an argument for it either way.

@jfrankl jfrankl self-assigned this Sep 21, 2020
@jfrankl jfrankl mentioned this issue Sep 22, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants