Fix prettier precommit for images #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to handle the current issue with being unable to commit images due to the precommit code throwing an error when trying to format images. This PR does fix the issue with the images, but there may be other file types in the future that encounter the same kind of problem. I have tried to account for the known file types for now.
While ideally we wouldn't need to specify all of the file types that we want to be formatted in the pre-commit script, I have not found any other method that works. Additionally, the .prettierignore config should already exclude the images, but the git-format-staged still seems to try to format the images first, which is where the problem is.