Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Changes #1154

Merged
merged 2 commits into from
Dec 17, 2018
Merged

API Changes #1154

merged 2 commits into from
Dec 17, 2018

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Nov 28, 2018

The schema looks like this:

"_content": {
    "file": "/pulp/api/v3/content/file/files/?repository_version=..."
},
"_content_added": {
    "file": "/pulp/api/v3/content/file/files/?repository_version_added=..."
},
"_content_removed": {}

Change the get_*content() functions to return a dictionary of types
matched to the respective list of content of that type.

Fix the get_artifact_paths() function to use those new functions
properly.

@dralley dralley force-pushed the api-changes branch 5 times, most recently from 463864e to 6d327d4 Compare December 3, 2018 14:44
dralley added a commit to dralley/pulp that referenced this pull request Dec 4, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 4, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 4, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 4, 2018
@dralley dralley mentioned this pull request Dec 4, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 4, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 5, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 5, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 6, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 10, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 11, 2018
dralley added a commit to dralley/pulp that referenced this pull request Dec 11, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 12, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 17, 2018
@nixocio
Copy link

nixocio commented Dec 17, 2018

Those changes were tested with the new API layout.

See: https://github.com/pulp/pulp_file/pull/133/files

dralley added a commit to dralley/pulp_rpm that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_rpm that referenced this pull request Dec 17, 2018
@nixocio
Copy link

nixocio commented Dec 17, 2018

@dralley , do you have any other change do add to this PR?

Tests passed in the other repo, if this is PR blocking the Pulp release, we can go ahead and merge this PR.

@dralley
Copy link
Contributor Author

dralley commented Dec 17, 2018

@kersommoura No others, but please review these. That way we can merged them all together to minimize the amount of breakage.

pulp/pulp#3774
pulp/pulp_file#133
pulp/pulp_rpm#1248

dralley added a commit to dralley/pulp_rpm that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_rpm that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_file that referenced this pull request Dec 17, 2018
@nixocio
Copy link

nixocio commented Dec 17, 2018

@dralley, I reviewed those changes related to the functional tests. I left minor comments.

@nixocio nixocio merged commit 81e0f25 into pulp:master Dec 17, 2018
This was referenced Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_ansible that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_ansible that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_ansible that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 17, 2018
dralley added a commit to dralley/pulp_python that referenced this pull request Dec 18, 2018
daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request May 14, 2019
daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants