-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Changes #1154
API Changes #1154
Conversation
463864e
to
6d327d4
Compare
Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp_file#133 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Those changes were tested with the new API layout. |
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
@dralley , do you have any other change do add to this PR? Tests passed in the other repo, if this is PR blocking the Pulp release, we can go ahead and merge this PR. |
@kersommoura No others, but please review these. That way we can merged them all together to minimize the amount of breakage. |
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
@dralley, I reviewed those changes related to the functional tests. I left minor comments. |
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
Required PR: pulp/pulp#3774 Required PR: pulp/pulp-smash#1154 [noissue]
The schema looks like this:
Change the get_*content() functions to return a dictionary of types
matched to the respective list of content of that type.
Fix the get_artifact_paths() function to use those new functions
properly.