[Do not Merge] Change name of "artifact" field to "_artifact" #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to change across all plugins. re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 30, 2019
Remove boilerplate from the plugins. Plugins must define a "multiple_artifacts_per_content" attribute on their Serializer subclass Meta class, and core will look at that to decide which to use. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 30, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
|
Just use Pavel's PR, I didn't see it |
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins. Plugins must define a "multiple_artifacts_per_content" attribute on their Serializer subclass Meta class, and core will look at that to decide which to use. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins. Plugins must define a "multiple_artifacts_per_content" attribute on their Serializer subclass Meta class, and core will look at that to decide which to use. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulpcore-plugin
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
3 tasks
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulpcore-plugin
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulpcore-plugin
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to change across all plugins.
re: #4366
https://pulp.plan.io/issues/4366