This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Add custom serializers for "_artifact" vs "_artifacts" #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
[noissue]
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1165 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
force-pushed
the
artifacts
branch
2 times, most recently
from
January 31, 2019 19:21
edc4068
to
e15c67e
Compare
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 40.55% 39.82% -0.73%
==========================================
Files 22 20 -2
Lines 688 678 -10
==========================================
- Hits 279 270 -9
+ Misses 409 408 -1
Continue to review full report at Codecov.
|
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
commented
Jan 31, 2019
@@ -81,37 +81,37 @@ def __init__(self, new_version, *args, **kwargs): | |||
self.new_version = new_version | |||
|
|||
async def __call__(self, in_q, out_q): | |||
""" | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This double-indentation was causing Travis to fail
jortel
approved these changes
Jan 31, 2019
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
May 14, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.
Required PR: pulp/pulp_file#159
Required PR: pulp/pulp#3846
Required PR: pulp/pulp-smash#1165
re: #4340
https://pulp.plan.io/issues/4340
re: #4366
https://pulp.plan.io/issues/4366
Pull Requests
Please be sure you have read our documentation regarding contributing
here:
https://docs.pulpproject.org/en/3.0/nightly/contributing/index.html
There you can read a Contribution Checklist and learn more about
appropriate branches and rebasing among other things.
Once you are ready to create a pull request:
documentation here:
https://docs.pulpproject.org/en/3.0/nightly/contributing/git.html#commit-message
your pull request into the notes/comments for the relevant bug in the
issue tracker and change the status to POST.
by your pull request. You can see the status of these tests on the
page for your pull request. If there are failures, please try to
fix them and update your pull request.
Thank you so much for contributing to Pulp!