Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Add custom serializers for "_artifact" vs "_artifacts" #38

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Jan 31, 2019

Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp#3846
Required PR: pulp/pulp-smash#1165

re: #4340
https://pulp.plan.io/issues/4340
re: #4366
https://pulp.plan.io/issues/4366

Pull Requests

Please be sure you have read our documentation regarding contributing
here:
https://docs.pulpproject.org/en/3.0/nightly/contributing/index.html

There you can read a Contribution Checklist and learn more about
appropriate branches and rebasing among other things.

Once you are ready to create a pull request:

  • For properly formatting commit messages, please see the
    documentation here:
    https://docs.pulpproject.org/en/3.0/nightly/contributing/git.html#commit-message
  • Once you have created your pull request, please add a link to
    your pull request into the notes/comments for the relevant bug in the
    issue tracker and change the status to POST.
  • Continuous integration tests will be automatically triggered
    by your pull request. You can see the status of these tests on the
    page for your pull request. If there are failures, please try to
    fix them and update your pull request.

Thank you so much for contributing to Pulp!

dralley added a commit to dralley/pulp_file that referenced this pull request Jan 31, 2019
dralley added a commit to dralley/pulp that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp-smash#1165
Required PR: pulp/pulpcore-plugin#38

re: #4340
https://pulp.plan.io/issues/4340
re: #4366
https://pulp.plan.io/issues/4366
dralley added a commit to dralley/pulp_file that referenced this pull request Jan 31, 2019
dralley added a commit to dralley/pulp_file that referenced this pull request Jan 31, 2019
dralley added a commit to dralley/pulp that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp-smash#1165
Required PR: pulp/pulpcore-plugin#38

re: #4340
https://pulp.plan.io/issues/4340
re: #4366
https://pulp.plan.io/issues/4366
dralley added a commit to dralley/pulp_file that referenced this pull request Jan 31, 2019
@dralley dralley force-pushed the artifacts branch 2 times, most recently from edc4068 to e15c67e Compare January 31, 2019 19:21
dralley added a commit to dralley/pulp that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp-smash#1164
Required PR: pulp/pulpcore-plugin#38

re: #4340
https://pulp.plan.io/issues/4340
re: #4366
https://pulp.plan.io/issues/4366
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #38 into master will decrease coverage by 0.72%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   40.55%   39.82%   -0.73%     
==========================================
  Files          22       20       -2     
  Lines         688      678      -10     
==========================================
- Hits          279      270       -9     
+ Misses        409      408       -1
Impacted Files Coverage Δ
pulpcore/plugin/serializers.py 100% <ø> (ø) ⬆️
pulpcore/plugin/stages/association_stages.py 20.68% <0%> (ø) ⬆️
pulpcore/plugin/models/__init__.py
pulpcore/plugin/models/content.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cfb26...2edd845. Read the comment docs.

dralley added a commit to dralley/pulp_file that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp#3846
Required PR: pulp/pulp-smash#1164

re: #4366
https://pulp.plan.io/issues/4366
dralley added a commit to dralley/pulp that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp-smash#1164
Required PR: pulp/pulpcore-plugin#38

re: #4366
https://pulp.plan.io/issues/4366
dralley added a commit to dralley/pulp that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp-smash#1164
Required PR: pulp/pulpcore-plugin#38

re: #4366
https://pulp.plan.io/issues/4366
dralley added a commit to dralley/pulp that referenced this pull request Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized
serializers for the single-artifact-per-content case, the
multiple-artifacts-per-content case, and the no-artifacts-per-content
case.

Required PR: pulp/pulp_file#159
Required PR: pulp/pulp-smash#1164
Required PR: pulp/pulpcore-plugin#38

re: #4366
https://pulp.plan.io/issues/4366
dralley added a commit to dralley/pulp_file that referenced this pull request Jan 31, 2019
@@ -81,37 +81,37 @@ def __init__(self, new_version, *args, **kwargs):
self.new_version = new_version

async def __call__(self, in_q, out_q):
"""
"""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This double-indentation was causing Travis to fail

@dralley dralley merged commit 682c657 into pulp:master Jan 31, 2019
@dralley dralley deleted the artifacts branch January 31, 2019 20:56
daviddavis pushed a commit to pulp/pulp_file that referenced this pull request Jan 31, 2019
daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants