Add ensure_teardownclass context manager to pulp_smash.utils
#1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unittest will not execute tearDownClass if an error occurs on classmethods this contextmanager will ensure that method is executed in case of error. Usage: ```py @classmethod def setUpClass(cls): with ensure_teardownclass(cls): 1 / 0 # raises ZeroDivisionError ``` without `ensure_teardownclass` after that exception, tearDownClass would never be executed, but the context manager ensure it.
nixocio
approved these changes
Mar 18, 2019
rochacbruno
added a commit
to rochacbruno/pulp-certguard
that referenced
this pull request
Mar 18, 2019
- Add testcase for certguard api (assert protected distribution) - Add a bunch if `dummy` generated self-signed certificates for testing purposes Requires PRs: pulp/pulp-smash#1184 pulp/pulp-smash#1185 pulp/pulp-smash#1186 pulp/pulp-smash#1187 Related issues: https://pulp.plan.io/issues/4122 https://pulp.plan.io/issues/3969 https://pulp.plan.io/issues/3970 closes #4122
rochacbruno
added a commit
to rochacbruno/pulp-certguard
that referenced
this pull request
Mar 19, 2019
- Add testcase for certguard api (assert protected distribution) - Add a some `dummy` generated self-signed certificates for testing purposes Related PRs: pulp/pulp-smash#1185 pulp/pulp-smash#1186 pulp/pulp-smash#1187 Related issues: https://pulp.plan.io/issues/4122 https://pulp.plan.io/issues/3969 https://pulp.plan.io/issues/3970 closes #4122 Required PR: pulp/pulp-smash#1184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittest will not execute tearDownClass if an error occurs on classmethods
this contextmanager will ensure that method is executed in case of error.
Usage:
without
ensure_teardownclassafter that exception, tearDownClasswould never be executed, but the context manager ensure it.