Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Everytime we instantiate a new instance of
cli.Client
its__init__
methodcode tries to make communication with the remote host to determine if it is
a local or ssh machine to be used.
The communication with
machine
should be done only when it is necessary,which is when the
run
command is called.To reproduce the problem
We have not called the run method, so the communication with server should not be done yet.
Solution:
Transform
machine
in a lazy@property
then it is instantiated onlywhen it is first called.
Not calling
run
When
run
is called