Add publication() #1194
Closed
Add publication() #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Apr 2, 2019
Required PR: pulp/pulp-smash#1194 closes #4378 https://pulp.plan.io/issues/4378
rochacbruno
reviewed
Apr 2, 2019
| client = api.Client(cfg, api.json_handler) | ||
| call_report = client.post(path, data) | ||
| tasks = tuple(api.poll_spawned_tasks(cfg, call_report)) | ||
| return client.get(tasks[-1]["created_resources"][0]) |
There was a problem hiding this comment.
The task_handler already does this for generic task based resource creation
https://github.com/PulpQE/pulp-smash/blob/master/pulp_smash/api.py#L205-L268
The only difference right now is that it is reading tasks[0] assuming it has only one, we can change to read tasks[-1] or make it a parameter.
nixocio
reviewed
Apr 3, 2019
| @@ -139,6 +139,27 @@ def publish(cfg, publisher, repo, version_href=None): | |||
| return client.get(tasks[-1]["created_resources"][0]) | |||
|
|
|||
|
|
|||
| def publication(cfg, path, repo, version_href=None, **kwargs): | |||
There was a problem hiding this comment.
|
@ipanova , can we add a simple commit message? If there is a related issue even better. Just to be consistent with what we have been doing. |
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Apr 3, 2019
Required PR: pulp/pulp-smash#1194 closes #4378 https://pulp.plan.io/issues/4378
|
based on the comments i am closing the pr and going to use task_hander. |
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Apr 3, 2019
Required PR: pulp/pulp-smash#1194 closes #4378 https://pulp.plan.io/issues/4378
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Apr 4, 2019
Required PR: pulp/pulp-smash#1194 closes #4378 https://pulp.plan.io/issues/4378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.