Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resulting cmake config relocatable #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bachp
Copy link

@bachp bachp commented Sep 28, 2018

This change avoids hardcoded install prefix in the p8-platform-config.cmake.
Especially important when doing cross compilation with Yocto for example.

This change avoids hardcoded install prefix in the p8-platform-config.cmake.
Especially important when doing cross compilation with Yocto for example.
@MartijnKaijser
Copy link

Maybe try here
https://github.com/xbmc/platform

@bachp
Copy link
Author

bachp commented Oct 25, 2018

@MartijnKaijser Is this project dead? Or why do you suggest https://github.com/xbmc/platform?

@malard
Copy link
Member

malard commented Oct 25, 2018

This project isn't dead, we will review next week, thanks for the contribution!

@bachp
Copy link
Author

bachp commented Oct 25, 2018

The patch landed in OpenEmbedded where it was required to build without errors.

@opdenkamp
Copy link
Contributor

I haven't checked cmake's commit history, but the links in the manual to get_filename_component() suggest that this has been added in cmake 3.0, so cmake_minimum_required() needs to be updated too:

cmake_minimum_required(VERSION 2.8.9)

It also needs a quick rebase because of b784c04

thanks

@bachp
Copy link
Author

bachp commented Nov 5, 2018

I need to verify, but it could be that b784c04 made this change obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants