This repository has been archived by the owner on May 22, 2020. It is now read-only.
Feature/return cas #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PumpkinSeed
suggested changes
Oct 1, 2019
operations.go
Outdated
| @@ -12,22 +12,24 @@ import ( | |||
|
|
|||
| type writerF func(string, string, interface{}, int) (gocb.Cas, error) | |||
| type readerF func(string, string, interface{}, int) (gocb.Cas, error) | |||
| type CAS map[string]gocb.Cas | |||
operations_test.go
Outdated
| if err != nil || id == "" { | ||
| t.Fatal(err) | ||
| } | ||
| if len(cas) != 3 { | ||
| t.Error("error") |
There was a problem hiding this comment.
Provide better error something like, t.Errorf("Cas should store 3 elements, instead of %d", len(cas)). We are writing these errors for people who possible won't know anything about the system.
operations_test.go
Outdated
| if err != nil || id == "" { | ||
| t.Error("Missing error") | ||
| } | ||
| if len(cas) != 1 { | ||
| t.Error("error") |
operations_test.go
Outdated
| if err != nil || id == "" { | ||
| t.Error("Missing error") | ||
| } | ||
| if len(cas) != 1 { | ||
| t.Error("error") |
operations_test.go
Outdated
| if err != nil || id == "" { | ||
| t.Error("Missing error") | ||
| } | ||
| if len(cas) != 1 { | ||
| t.Error("error") |
PumpkinSeed
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39