Use CMAKE_TOOLCHAIN_FILE variable #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one were to build this project on Linux, it would fail because CMake would send Linux ld flags to the Darwin ld, which uses a completely different syntax. This required breaking out the tools into a separate CMake invocation. I have verified that the entire project builds from an empty build folder following these changes.
wjk
force-pushed
the
crosscompile-properly
branch
from
c6e2b18
to
a66e5f7
Compare
Previously, it would build if one first built the tools-extproj target manually first. This is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mot of this PR separates the tools directory out into a completely separate CMake run so I can use the
CMAKE_TOOLCHAIN_FILEvariable to fully and properly cross-compile PureDarwin. Previously, if I tried building PureDarwin on a non-macOS host, CMake would use Linux linker args that are incompatible with our ld64. This has been fixed.