Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI build fix; #153

Merged
merged 18 commits into from Feb 11, 2017
Merged

Travis CI build fix; #153

merged 18 commits into from Feb 11, 2017

Conversation

Antondomashnev
Copy link
Contributor

@Antondomashnev Antondomashnev commented Sep 16, 2016

Hi there,
This PR addresses the issue #148 . I was following the idea of having PL prefix for each macro.
As a suggestion @mickeyreiss what do you think about treating warnings as errors?

Also, I had to specify the ruby version to be able to run travis with slather gem.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage remained the same at 83.201% when pulling cd1aa6b on conichiGMBH:antondomashnev/fix_macro_reserved_warning into 4f64fff on PureLayout:master.

@Antondomashnev
Copy link
Contributor Author

@mickeyreiss weird, but one of three jobs was failed. Don't know the reason yet.

@Lutzifer
Copy link
Contributor

Lutzifer commented Dec 7, 2016

Looks more like a travis problem to me, than an actual problem with the code, can we get this merged?

@lkraider
Copy link
Member

Already fixed with the merge of #154 (which has essentially the same changes). A new PR with travis fixes would be nice.

@Antondomashnev
Copy link
Contributor Author

@lkraider do you have any idea what could be with Travis?

@lkraider
Copy link
Member

lkraider commented Jan 11, 2017

Seems Ruby 2.3 binary is not available (we are using 10.9 env it seems):
https://rvm.io/binaries/osx/10.9/x86_64/

I think we need to:

  • bump env to 10.11
  • specify ruby 2.2 in .ruby-version
  • build ruby 2.3 from source in before_install

references:
rvm/rvm#3686
travis-ci/travis-ci#5361

@Antondomashnev
Copy link
Contributor Author

@lkraider thanks, I'll double check the travis error and will try to submit an update.

@Antondomashnev
Copy link
Contributor Author

Hi folks, the Travis build is fixed, I'll rename the PR.

@Antondomashnev Antondomashnev changed the title Rename define __NSMutableArray_of into PL__NSMutableArray_of; Travis CI build fix; Jan 18, 2017
@lkraider
Copy link
Member

Awesome, great work!

@mhillebrand
Copy link

I would love to see this get merged.

@mickeyreiss mickeyreiss merged commit ec36e0f into PureLayout:master Feb 11, 2017
@Antondomashnev Antondomashnev deleted the antondomashnev/fix_macro_reserved_warning branch February 11, 2017 13:45
@mhillebrand
Copy link

Sweet! Thanks, @mickeyreiss. No more warnings when using Carthage. 😄 Now what about creating a new tag, since that's what Carthage looks for by default?

@mickeyreiss
Copy link
Contributor

mickeyreiss commented Feb 11, 2017

@mhillebrand Yep - I think it's about time to cut the release 📦 🦆

BTW - @mhillebrand @lkraider @Lutzifer I'd like to enlist your help maintaining the library. If you're interested, please contact me by email or on twitter.

@mhillebrand
Copy link

@mickeyreiss I'd be honored. PureLayout kicks ass. Maybe I could help convert the code to Swift?

@Antondomashnev
Copy link
Contributor Author

@mickeyreiss I would also love to help converting it to swift 😄

@Lutzifer
Copy link
Contributor

@mickeyreiss As I do not know, how much time i will be able to contribute I will keep doing PRs if necessary 😉

@lkraider
Copy link
Member

@mickeyreiss Would love to contribute more, we use PureLayout in most our projects @nKey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants