-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI build fix; #153
Travis CI build fix; #153
Conversation
@mickeyreiss weird, but one of three jobs was failed. Don't know the reason yet. |
Don't want Xcode to go "Fix issues" behind your back
Compiler warnings
Xcode 8 + Swift 3
Looks more like a travis problem to me, than an actual problem with the code, can we get this merged? |
Already fixed with the merge of #154 (which has essentially the same changes). A new PR with travis fixes would be nice. |
@lkraider do you have any idea what could be with Travis? |
Seems Ruby 2.3 binary is not available (we are using 10.9 env it seems): I think we need to:
references: |
@lkraider thanks, I'll double check the travis error and will try to submit an update. |
…m:conichiGMBH/PureLayout into antondomashnev/fix_macro_reserved_warning
Hi folks, the Travis build is fixed, I'll rename the PR. |
Awesome, great work! |
I would love to see this get merged. |
Sweet! Thanks, @mickeyreiss. No more warnings when using Carthage. 😄 Now what about creating a new tag, since that's what Carthage looks for by default? |
@mhillebrand Yep - I think it's about time to cut the release 📦 🦆 BTW - @mhillebrand @lkraider @Lutzifer I'd like to enlist your help maintaining the library. If you're interested, please contact me by email or on twitter. |
@mickeyreiss I'd be honored. PureLayout kicks ass. Maybe I could help convert the code to Swift? |
@mickeyreiss I would also love to help converting it to swift 😄 |
@mickeyreiss As I do not know, how much time i will be able to contribute I will keep doing PRs if necessary 😉 |
@mickeyreiss Would love to contribute more, we use PureLayout in most our projects @nKey. |
Hi there,
This PR addresses the issue #148 . I was following the idea of having PL prefix for each macro.
As a suggestion @mickeyreiss what do you think about treating warnings as errors?
Also, I had to specify the ruby version to be able to run travis with slather gem.