Solve at runtime level wrong UI AccountID32 matching #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
the
B7-runtimenoteworthy
librelois
approved these changes
Dec 10, 2021
JoshOrndorff
approved these changes
Dec 10, 2021
girazoki
deleted the
girazoki-use-slice-instead-of-accountid32-in-crowdloan-relay-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It solves polkadot-js/apps#6592 at the runtime level, which currently is preventing users from changing their reward address through the UI.
AccountId32 and [u8;32] encode equally so no need to worry for migrations (I added a test asserting that, which we can remove if we feel its not needed).
I am happy to wait for the UI changes, this PR is just in case we want to accelerate the process
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?