-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XCM to moonriver runtime #1087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
A0-pleasereview
Pull request needs code review.
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Dec 15, 2021
…okens-in-moonriver
…okens-in-moonriver
…individual-message-weight-for-transact' into girazoki-allow-xtokens-in-moonriver
…-runtime-max-individual-message-weight-for-transact
girazoki
changed the base branch from
master
to
girazoki-limit-in-runtime-max-individual-message-weight-for-transact
December 16, 2021 17:48
…individual-message-weight-for-transact' into girazoki-allow-xtokens-in-moonriver
Base automatically changed from
girazoki-limit-in-runtime-max-individual-message-weight-for-transact
to
master
December 17, 2021 09:22
…okens-in-moonriver
nanocryk
reviewed
Dec 17, 2021
nanocryk
approved these changes
Dec 17, 2021
JoshOrndorff
approved these changes
Dec 17, 2021
notlesh
added
D1-audited👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
and removed
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A0-pleasereview
Pull request needs code review.
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D1-audited👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Expect chaos.
This only adds:
It does not include the possibility to send our native token
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?