Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XCM to moonriver runtime #1087

Merged
merged 28 commits into from
Dec 17, 2021
Merged

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Dec 15, 2021

What does it do?

Expect chaos.

This only adds:

  • dmp and xcmp queues.
  • Adapters for those assets that are declared in AssetManager
  • xtokens
  • XcmTransactor

It does not include the possibility to send our native token

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@girazoki girazoki added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 15, 2021
@librelois librelois mentioned this pull request Dec 16, 2021
25 tasks
@girazoki girazoki marked this pull request as ready for review December 16, 2021 14:06
@girazoki girazoki changed the base branch from master to girazoki-limit-in-runtime-max-individual-message-weight-for-transact December 16, 2021 17:48
…individual-message-weight-for-transact' into girazoki-allow-xtokens-in-moonriver
Base automatically changed from girazoki-limit-in-runtime-max-individual-message-weight-for-transact to master December 17, 2021 09:22
runtime/moonriver/src/lib.rs Show resolved Hide resolved
@girazoki girazoki merged commit bd99af1 into master Dec 17, 2021
@girazoki girazoki deleted the girazoki-allow-xtokens-in-moonriver branch December 17, 2021 15:34
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants