XCM to moonbeam #1183
Merged
XCM to moonbeam #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
A0-pleasereview
crystalin
approved these changes
Jan 18, 2022
nanocryk
approved these changes
Jan 18, 2022
runtime/moonbeam/src/lib.rs
Outdated
| /// This is the struct that will handle the revenue from xcm fees | ||
| /// We do not burn anything because we want to mimic exactly what | ||
| /// the sovereign account has | ||
| pub type XcmFeesToAccount_ = XcmFeesToAccount< |
There was a problem hiding this comment.
Code style: avoid leading underscore, refer to original type explicitely (and don't import it)
Suggested change
| pub type XcmFeesToAccount_ = XcmFeesToAccount< | |
| pub type XcmFeesToAccount = xcm_primitives::XcmFeesToAccount< |
(also change other occurencies of XcmFeesToAccount_)
runtime/moonbeam/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// The hooks we wantt to run in Maintenance Mode |
There was a problem hiding this comment.
Suggested change
| /// The hooks we wantt to run in Maintenance Mode | |
| /// The hooks we want to run in Maintenance Mode |
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?