Orbiters: add storage entry RegisteredOrbiter & events OrbiterRegistered & OrbiterUnRegistered #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
girazoki
reviewed
Jun 13, 2022
| @@ -307,7 +319,13 @@ pub mod pallet { | |||
| &T::OrbiterReserveIdentifier::get(), | |||
| &orbiter, | |||
| min_orbiter_deposit, | |||
| ) | |||
| )?; | |||
| RegisteredOrbiter::<T>::insert(&orbiter, true); | |||
There was a problem hiding this comment.
Changes benchmark, although if this is a rush I dont think there is much issue with this
There was a problem hiding this comment.
I can add a write to the weighInfo impl
girazoki
approved these changes
Jun 13, 2022
4meta5
approved these changes
Jun 13, 2022
4meta5
approved these changes
Jun 13, 2022
nbaztec
reviewed
Jun 13, 2022
pallets/moonbeam-orbiters/src/lib.rs
Outdated
| deposit: BalanceOf<T>, | ||
| }, | ||
| /// An orbiter has unregistered | ||
| OrbiterUnRegistered { account: T::AccountId }, |
There was a problem hiding this comment.
Suggested change
| OrbiterUnRegistered { account: T::AccountId }, | |
| OrbiterUnregistered { account: T::AccountId }, |
Unregistered is a single word so camelcase isn't needed
4meta5
reviewed
Jun 13, 2022
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
nbaztec
approved these changes
Jun 13, 2022
librelois
added a commit
that referenced
this pull request
Jun 13, 2022
…red & OrbiterUnRegistered (#1593) * feat(orbiter): add storage entry RegisteredOrbiter * feat(orbiter): add events OrbiterRegistered & OrbiterUnRegistered * Adapt rust tests * fmt * account 1 more write for orbiters register and unregister * fix case * Update pallets/moonbeam-orbiters/src/lib.rs Co-authored-by: Amar Singh <asinghchrony@protonmail.com> Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
|
Let's not forget to do a follow-up with ts-test to it @librelois |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Theoretically, it would be necessary to make a migration but as the orbiter is not used yet in the production networks, it will not be implemented.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?