-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bake in chain specs #169
Merged
Merged
Bake in chain specs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4meta5
reviewed
Jan 8, 2021
JoshOrndorff
commented
Jan 8, 2021
crystalin
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about the relay spec template being removed, otherwise it looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
The baked-in specs currently on this PR are mocks. They are just the default rococo-local and moonbead dev specs. I suggest we merge this PR with the mock specs once we are happy with the code and the process around it. Then when we are ready to release moonbeam v0.5, we make one more commit with the real alphanet specs.
This process is already precedented in popular live Substrate-based chains like Polkadot, Kulupu, and Edgeware.
What value does it bring to blockchain users?
Users who run their own nodes on common networks like alphanet, moonriver and moonrock will not have to manually specify chain specs on their CLI.
Proposed Network Launch Process
Baking specs into the binary is a big win for moonbase operators and support staff. However it does require a coordinate release process. The release process would look roughly like this.
v0.5.0-rc1
.v0.5.0
).Checklist