Avoid binary search over potentially unsorted data #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
added
B7-runtimenoteworthy
crystalin
approved these changes
Apr 19, 2023
librelois
approved these changes
Apr 19, 2023
librelois
pushed a commit
that referenced
this pull request
Apr 20, 2023
* Avoid binary search over potentially unsorted data * Slight improvement in regression test * Err, this is how you would test empty vec... * Better test * Toml sort --------- Co-authored-by: crystalin <alan.sapede@gmail.com>
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
…on#2247) * Avoid binary search over potentially unsorted data * Slight improvement in regression test * Err, this is how you would test empty vec... * Better test * Toml sort --------- Co-authored-by: crystalin <alan.sapede@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Trackscan potentially be unsorted, so we don't want to perform abinary_search_by_key()on it. Instead, we do an linear search.The performance impact depends on the number of tracks. Assuming there aren't a lot of tracks, I suspect that
find()performs as well as or better thanbinary_searchanyway.