Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Moonriver ReferendumCanceller track support ceiling #2281

Merged
merged 3 commits into from
May 23, 2023
Merged

Fix Moonriver ReferendumCanceller track support ceiling #2281

merged 3 commits into from
May 23, 2023

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented May 5, 2023 •
edited by crystalin
Loading

What does it do?

Adjust the "referendum canceller" track's support curve ceiling in Moonriver to be in line with the Foundation's proposal

⚠️ Breaking Changes ⚠️

  • Referendum Canceller (Moonriver only) track support curve is fixed. Changing from Curve::make_reciprocal(1, 14, percent(1), percent(0), percent(50)) to
    Curve::make_reciprocal(1, 14, percent(1), percent(0), percent(10))

@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels May 5, 2023
@fgamundi fgamundi marked this pull request as ready for review May 5, 2023 13:43
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

Coverage generated "Mon May 22 15:25:08 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2281/html/index.html

Master coverage: 72.42%
Pull coverage: 72.42%

@fgamundi fgamundi added the A0-pleasereview Pull request needs code review. label May 18, 2023
@fgamundi fgamundi merged commit ae39738 into master May 23, 2023
26 checks passed
@fgamundi fgamundi deleted the fg-refkiller-curve branch May 23, 2023 12:17
timbrinded pushed a commit that referenced this pull request Jun 2, 2023
@fgamundi @timbrinded
Moonriver RefCanceller track support ceiling (#2281)
17c9fee
@crystalin crystalin changed the title Moonriver RefCanceller track support ceiling Fix Moonriver ReferendumCanceller track support ceiling Jun 9, 2023
@eshaben eshaben mentioned this pull request Jun 27, 2023
Merged
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgamundi @crystalin @notlesh @librelois