Enable Xcm->Evm and Erc20Xcm on Moonriver & Moonbeam #2318
Conversation
librelois
added
B7-runtimenoteworthy
|
Coverage generated "Tue May 30 10:49:08 UTC 2023": Master coverage: 70.87% |
librelois
changed the title
| @@ -324,3 +324,14 @@ export function describeDevMoonbeamAllEthTxTypes( | |||
| describeDevMoonbeam(title + " (EIP1559)", cb, "EIP1559", "moonbase", wasm); | |||
| describeDevMoonbeam(title + " (EIP2930)", cb, "EIP2930", "moonbase", wasm); | |||
| } | |||
|
|
|||
| export function describeDevMoonbeamAllRuntimes( | |||
There was a problem hiding this comment.
Is this being used anywhere? Some uncommitted file?
There was a problem hiding this comment.
Yeah, I had started working locally on extending some XCM ts tests to moonriver and moonbeam, but most xcm tests need sudo
There was a problem hiding this comment.
There is the democracy helper for that but it will get removed once we move to Referenda.
Do you think it would make sense to restore sudo under a feature flag in the runtimes for testing purposes ?
Or to allow the client to override storage for testing (not sure the impact on the test however, specially the tree checks)
There was a problem hiding this comment.
I'd be interested on the feature flag, the last time I tried I could not make it work since I could not make it under the construct_runtime macro..
There was a problem hiding this comment.
I think it's much simpler to add an RPC method allowing the client to modify the storage, I think we should avoid having to compile a special runtime just for testing.
| Weight::from_parts( | ||
| T::Erc20TransferGasLimit::get().saturating_mul(T::WeightPerGas::get().ref_time()), | ||
| 0, | ||
| gas_limit / 4, // TODO: apply gas/proof_size ratio |
There was a problem hiding this comment.
Not related to this PR but could erc20-xcm-bridge not be a pallet? it has no events, no storage and no extrinsic AFAICT. What is the purpose of making it a pallet?
There was a problem hiding this comment.
@girazoki The point of making it a pallet is to identify the multilocation namespace by a PalletIndex. It allows remote chains to query which pallet index is being used to send us erc20s.
There was a problem hiding this comment.
Oh ok, this could have been done with some other junction though, maybe worth giving it a thought. Although it might be already late. Not very important though
librelois
added
not-breaking
notlesh
added
D1-audited👍
What does it do?
Enables the following features in Moonriver & Moonbeam runtimes:
DescendOrigin+WithdrawAsset+BuyExecutionmessages.describeMoonbeamDevAllRuntimes, to make sure I configured everything correctly for all runtimesWhat important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?