Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GMP precompile to Moonriver and Moonbeam runtimes #2327

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Add GMP precompile to Moonriver and Moonbeam runtimes #2327

merged 1 commit into from
Jun 6, 2023
+10 −2

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Jun 5, 2023

What does it do?

Adds GMP precompile to both Moonriver and Moonbeam.

Note that the precompile will default to disabled in both cases (because of #2292).

@notlesh notlesh added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Coverage generated "Mon Jun 5 18:41:25 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2327/html/index.html

Master coverage: 70.87%
Pull coverage: 70.87%

@librelois librelois mentioned this pull request Jun 6, 2023
Closed
24 tasks
@librelois librelois merged commit c9938c5 into master Jun 6, 2023
32 checks passed
@librelois librelois deleted the notlesh-gmp-moonriver-moonbeam branch June 6, 2023 14:44
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgmichel tgmichel tgmichel approved these changes

@girazoki girazoki girazoki approved these changes

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notlesh @tgmichel @girazoki @librelois