-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves XCM barrier for DescendOrigin #2335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Agusrodri @girazoki I think we should remove our custom AllowTopLevelPaidExecutionDescendOriginFirst
barrier, and use WithComputedOrigin
like polkadot: https://github.com/paritytech/polkadot/blame/master/runtime/polkadot/src/xcm_config.rs#L163
Coverage generated "Thu Jun 8 08:40:14 UTC 2023": Master coverage: 71.22% |
Fully agree @librelois, I forgot about these new Barrier |
This PR removes our custom barrier
AllowTopLevelPaidExecutionDescendOriginFirst
and uses the polkadot barrierWithComputedOrigin
instead.Our custom barrier
AllowTopLevelPaidExecutionDescendOriginFirst
was originally created to test xcm->evm on moonbase as a copy ofAllowTopLevelPaidExecutionFrom
but withDescendOrigin
instead ofClearOrigin
.At the time, polkadot didn't offer any barriers to support
DescendOrigin
instruction, so it made sense to create our own, but that's no longer the case.Parity has developed a generic barrier
WithComputedOrigin
that wraps existing barriers and handle the prefixedDescendOrigin
instruction. Now, all relays and system parachains like statemine use this new barrier this way: