add cli option --eth-log-block-cache #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
the
B5-clientnoteworthy
girazoki
approved these changes
Oct 14, 2021
notlesh
reviewed
Oct 14, 2021
| max_past_logs, | ||
| network: network.clone(), |
There was a problem hiding this comment.
it looks like your editor rearranged these in alphabetical order, which might cause some merge headaches. this seems fine to me as long as we're intentional and consistent about it
There was a problem hiding this comment.
It's not my editor, it's intentional.
| @@ -169,6 +169,10 @@ pub struct RunCmd { | |||
| #[structopt(long, default_value = "300")] | |||
| pub ethapi_trace_cache_duration: u64, | |||
|
|
|||
| /// Size of the LRU cache for block data and their transaction statuses. | |||
| #[structopt(long, default_value = "3000")] | |||
| pub eth_log_block_cache: usize, | |||
There was a problem hiding this comment.
Why is this one usize and the others are u32 or u64? I don't see any problems, just curious about this.
There was a problem hiding this comment.
Because the LruCache is waiting for a usize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?