Initial review of Moonbeam (Phase 0) #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystalin
added
A0-pleasereview
JoshOrndorff
approved these changes
Oct 25, 2021
runtime/moonbeam/src/lib.rs
Outdated
Comment on lines
89
to
90
| pub const MOONRIVER_FACTOR: Balance = 100; // 100 more total supply | ||
|
|
There was a problem hiding this comment.
Since Moonbeam is the flagship product, does it make more sense to have such a factor in the Moonriver runtime?
There was a problem hiding this comment.
It does, but this would imply division (or multiplying by a fraction) :)
I agree, though, it makes more sense to define this either (1) as a portion of total/genesis supply or (2) relative to GMLR
| /// Default BlocksPerRound is every hour (300 * 12 second block times) | ||
| pub const DefaultBlocksPerRound: u32 = 300; | ||
| /// Collator candidate exits are delayed by 2 hours (2 * 300 * block_time) | ||
| /// Default BlocksPerRound is every 4 hours (1200 * 12 second block times) |
There was a problem hiding this comment.
Suggested change
| /// Default BlocksPerRound is every 4 hours (1200 * 12 second block times) | |
| /// Default BlocksPerRound is every 4 hours |
librelois
approved these changes
Oct 25, 2021
4meta5
approved these changes
Oct 26, 2021
4meta5
reviewed
Oct 26, 2021
4meta5
reviewed
Oct 26, 2021
crystalin
changed the title
nanocryk
approved these changes
Oct 28, 2021
notlesh
reviewed
Oct 28, 2021
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.