This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Fixed location of 'host' in ingress rules #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiberiuvs
approved these changes
Oct 1, 2019
Pure-AdamuKaapan
force-pushed
the
SSLFix
branch
from
8d014ab
to
6c9b689
Compare
|
Tested in person, finally got it sorted out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted fix for #9. Looks like the host parameter for the HTTP rules was in the wrong place, and since the route host didn't match the TLS host, it didn't use that cert and used the default instead.
WIP, waiting for build so I can test.