Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rpm spec's #1084

Merged
merged 7 commits into from
Feb 1, 2018
Merged

fix rpm spec's #1084

merged 7 commits into from
Feb 1, 2018

Conversation

r4sas
Copy link
Member

@r4sas r4sas commented Feb 1, 2018

  • added spec for git package
  • fixed double slashes
  • changed versioning for stable builds

@r4sas r4sas requested a review from l-n-s February 1, 2018 05:39
@r4sas
Copy link
Member Author

r4sas commented Feb 1, 2018 •
edited

One more question is about Obsoletes tag - we need it? I think no.
https://wiki.mageia.org/en/RPM_Spec_file_policy#Requires.2C_Obsoletes.2C_Provides.2C_Conflicts.2C_etc.

l-n-s
l-n-s reviewed Feb 1, 2018
View reviewed changes
Copy link
Member

@l-n-s l-n-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. For rpm spec look at Fedora wiki, it's more up-to-date.

@l-n-s
Copy link
Member

l-n-s commented Feb 1, 2018

Obsoletes tag is there to remove @BOPOHA systemd subpackage. But, I guess we broke his repo completely already, so IDK.

@r4sas r4sas merged commit 180730f into PurpleI2P:openssl Feb 1, 2018
@BOPOHA BOPOHA mentioned this pull request Feb 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-n-s l-n-s l-n-s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r4sas @l-n-s