add take operations to Batch (#583) #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesmith00000
approved these changes
Aug 20, 2023
|
The build is struggling, but I don't currently believe it has anything to do with this work, will investigate later. |
|
I'm merging this commit because I think you've just been unlucky and we're running out of memory or something. I'll fix the CI job separately. I've run the code locally and it works just fine. |
|
Yeah, main branch build is absolutely fine. I upgraded sbt too but as I say, I think you were just unlucky. Thanks again for the contribution, apologies for the slow response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wrapped the js.Array methods. Did you have more in mind than that?
Fixes #583