...

Pushword · Feb 2, 2022 · 1264b79 · 1264b79
1 parent 11ab9c3
commit 1264b79
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/packages/conversation/src/Form/FormTrait.php b/packages/conversation/src/Form/FormTrait.php
@@ -48,13 +48,13 @@ trait FormTrait
 
     protected Twig $twig;
 
-    protected \Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface $security;
+    protected TokenStorageInterface $security;
 
-    protected \Symfony\Component\Form\FormFactory $formFactory;
+    protected FormFactory $formFactory;
 
-    protected \Symfony\Contracts\Translation\TranslatorInterface $translator;
+    protected TranslatorInterface $translator;
 
-    protected \Symfony\Bundle\FrameworkBundle\Routing\Router $router;
+    protected Router $router;
 
     /** @var int */
     protected $currentStep;
@@ -66,13 +66,11 @@ trait FormTrait
      */
     protected string $messageEntity;
 
-    /** @var MessageInterface */
-    protected $message;
+    protected MessageInterface $message;
 
-    protected \Pushword\Core\Component\App\AppPool $apps;
+    protected AppPool $apps;
 
-    /** @var AppConfig */
-    protected $app;
+    protected AppConfig $app;
 
     /**
      * @param class-string<MessageInterface> $messageEntity

diff --git a/packages/conversation/src/Service/NewMessageMailNotifier.php b/packages/conversation/src/Service/NewMessageMailNotifier.php
@@ -100,7 +100,7 @@ public function send()
         }
 
         $lastTime = new LastTime($this->projectDir.'/var/lastNewMessageNotification');
-        if (true === $lastTime->wasRunSince(new DateInterval($this->interval))) {
+        if ($lastTime->wasRunSince(new DateInterval($this->interval))) {
             $this->logger->info('Not sending conversation notification : a previous notification was send not a long time ago ('.$this->interval.', see `conversation_notification_interval`).');
 
             return;

diff --git a/packages/core/src/DependencyInjection/PushwordConfigFactory.php b/packages/core/src/DependencyInjection/PushwordConfigFactory.php
@@ -179,6 +179,7 @@ private function loadToParameters(array $config, string $prefix = ''): void
 
     /**
      * @param array<mixed>|bool|string|int|float|null $value The parameter value
+     * @noRector
      */
     private function setParameter(string $key, $value): void
     {

diff --git a/packages/page-update-notifier/src/PageUpdateNotifier.php b/packages/page-update-notifier/src/PageUpdateNotifier.php
@@ -98,7 +98,7 @@ public function postPersist(PageInterface $page): void
     {
         try {
             $this->run($page);
-        } catch (Exception $e) {
+        } catch (Exception $exception) {
             // todo log exception
         }
     }

diff --git a/rector.php b/rector.php
@@ -124,7 +124,6 @@ function ($path) { return __DIR__.'/'.$path; },
     $services->set(RecastingRemovalRector::class);
     $services->set(RemoveAlwaysTrueIfConditionRector::class);
     $services->set(RemoveAndTrueRector::class);
-    $services->set(RemoveAssignOfVoidReturnFunctionRector::class);
     $services->set(RemoveDeadIfForeachForRector::class);
     $services->set(AddArrayParamDocTypeRector::class);
     $services->set(AddClosureReturnTypeRector::class);