fix test & psalm

Pushword · Feb 2, 2022 · 8906eff · 8906eff
1 parent effbbd9
commit 8906eff
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/packages/conversation/tests/Controller/ConversationFormControllerTest.php b/packages/conversation/tests/Controller/ConversationFormControllerTest.php
@@ -3,17 +3,16 @@
 namespace Pushword\Conversation\Tests\Controller;
 
 use Pushword\Conversation\Controller\ConversationFormController;
-use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
-use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Panther\PantherTestCase;
 
-class ConversationFormControllerTest extends KernelTestCase
+class ConversationFormControllerTest extends PantherTestCase
 {
     public function testShowHomepage()
     {
-        $request = Request::create('/testit?referring=test&type=ms-message');
-        $request->headers->set('origin', 'https://localhost.dev');
-        $response = $this->getController()->show($request, 'message', 'localhost.dev');
-        $this->assertSame(200, $response->getStatusCode());
+        $client = static::createClient();
+
+        $client->request('POST', '/conversation/message/test', [], [], ['HTTP_ORIGIN' => 'https://localhost.dev']);
+        $this->assertEquals(200, $client->getResponse()->getStatusCode());
     }
 
     /**

diff --git a/packages/core/src/Utils/LastTime.php b/packages/core/src/Utils/LastTime.php
@@ -40,6 +40,9 @@ public function get(?string $default = null): ?\DateTimeInterface
         return new DateTime('@'.\Safe\filemtime($this->filePath));
     }
 
+    /**
+     * @psalm-suppress InvalidNullableReturnType
+     */
     public function safeGet(string $default): \DateTimeInterface
     {
         return $this->get($default); // @phpstan-ignore-line

diff --git a/packages/skeleton/var/app.db b/packages/skeleton/var/app.db
diff --git a/packages/static-generator/src/Generator/MediaGenerator.php b/packages/static-generator/src/Generator/MediaGenerator.php
@@ -28,7 +28,7 @@ protected function copyMediaToDownload(): void
         }
 
         $dir = dir($mediaDir);
-        if (\in_array($dir, [null, false], true)) {
+        if (false === $dir) {
             return;
         }