Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #44 #52

Merged
merged 15 commits into from Nov 7, 2022
Merged

Issue #44 #52

merged 15 commits into from Nov 7, 2022

Conversation

DavidCano98
Copy link
Contributor

What have you Changed

1. Data should be generated based on Gender. fname file will be rewritten. There will be 2 files.

  • added files fnames_male.txt and fnames_female.txt (male names from original file, new random female names)
  • added cli arguments -ma/--male and -fe/--female to specify generating only specific gender
  • when not specified, generating randomly from both genders
  • added Gender enum
  • added Gender parameter into multiple functions, to specify gender

2. Generate Geo Coordinate, should be from the same city.

  • changed cities_name.txt data to for example
    Metropolis;22.574280;113.932504
  • each city has two coordinates of a randomly picked city on Earth
  • added function generate_random_city_coords(cities) to generate random city from list with random coordinates
  • function random_coords_from_point(lat: float, lon: float, max_distance: float = 1000) generates a random coordinate point away max. max_distance meters, away from point (lat, lon)
  • by default, generates random points in a 1 kilometer radius circle in each city

3. Generate Father/Mother's name as well in the profile section.

  • when generating a full profile, generates one female and one male name coresponding to mother/father, with the same last name as original profile last name
  • parents are stored in output fields mother and father

4. Generate fake Credit/Debit Card

  • added function generate_random_card() that outputs a dictionary with structur:

`{

  "type": "Credit"/"Debit",

  "number": "nnnn-nnnn-nnnn-nnnn",

  "expiration": "mm/yy"

}`

  • expiration is random month in the next ten years

5. with the job title there should be job experience it should match with age

  • added job_levels.txt with data:

    `entry-level;0;22

    intermediate;23;26

    mid-level;27;37

    senior;38;50

    executive;51;100`

  • first part is level name, other two are minimal and maximal age for level

  • generate_random_job_level(age: int, levels) to get matching job level for given age

Issue no.(must) - 44

Proposed feature in upcoming version

Self Check(Tick After Making pull Request)

  • One Change in one Pull Request
  • I am following clean code and Documentation and my code is well linted with flake8.

@codeperfectplus codeperfectplus linked an issue Nov 7, 2022 that may be closed by this pull request
@codeperfectplus codeperfectplus merged commit 7040dc5 into Py-Contributors:dev Nov 7, 2022
codeperfectplus added a commit that referenced this pull request Nov 17, 2022
* better cli output

* updating documentation

* updating documentation

* updating badge

* updating changelog

* Update publish.yml

* updating setup.py

* Update README.md

* first stable release

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* Update CHANGELOG.md

* updating cli

* refactoring code

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* fixing flake8 error

* bug fixed

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* tested

* flake8 error

* flake8 error

* refactroing code

* updating docs

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* test cases updated

* test cases updated

* adding scripts for release automation (#49)

* bumping version 1.0.0 to 2.0.0 (#50)

* adding scripts for release automation

* v2.0.0 releasing

* updating changelog

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* Delete update_package.sh

* Update FUNDING.yml

* Update FUNDING.yml

* Issue #44 (#52)

* add gender options for first names

* add gender options for first names, random card

* add job experience according to years of age

* add parameter option for logging (not implemented yet)

* add handpicked locations to cities in list

* add float coords generation

* add coordinates string formatting

* fix ages in job level generation

* start of unit tests

* add more tests

* add assertregex ussage in tests

* fix missing imports

* lint fixes

* two lines padding before class

* solving git conflict

* refactoring code

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* refacoting code and changelog update

* Update FUNDING.yml

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>
Co-authored-by: Rahul Sharma <53327705+DrakeEntity@users.noreply.github.com>
Co-authored-by: DavidCano98 <63115730+DavidCano98@users.noreply.github.com>
codeperfectplus added a commit that referenced this pull request Nov 17, 2022
* better cli output

* updating documentation

* updating documentation

* updating badge

* updating changelog

* Update publish.yml

* updating setup.py

* Update README.md

* first stable release

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* Update CHANGELOG.md

* updating cli

* refactoring code

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* fixing flake8 error

* bug fixed

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* tested

* flake8 error

* flake8 error

* refactroing code

* updating docs

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* test cases updated

* test cases updated

* adding scripts for release automation (#49)

* bumping version 1.0.0 to 2.0.0 (#50)

* adding scripts for release automation

* v2.0.0 releasing

* updating changelog

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* Delete update_package.sh

* Update FUNDING.yml

* Update FUNDING.yml

* Issue #44 (#52)

* add gender options for first names

* add gender options for first names, random card

* add job experience according to years of age

* add parameter option for logging (not implemented yet)

* add handpicked locations to cities in list

* add float coords generation

* add coordinates string formatting

* fix ages in job level generation

* start of unit tests

* add more tests

* add assertregex ussage in tests

* fix missing imports

* lint fixes

* two lines padding before class

* solving git conflict

* refactoring code

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>

* refacoting code and changelog update

* Update FUNDING.yml

* fixing bug the project link and formated code base with flake8 (#53)

Signed-off-by: Deepak Raj <54245038+codePerfectPlus@users.noreply.github.com>
Co-authored-by: Rahul Sharma <53327705+DrakeEntity@users.noreply.github.com>
Co-authored-by: DavidCano98 <63115730+DavidCano98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Proposed feature in upcoming version
2 participants