Fix buffer_size calculations for AudioFrame planes #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes several misunderstandings concerning AudioFrame buffer sizes: - for audio, "line size" and "buffer size" are equivalent, as there is only ever a single "line". - only linesizes[0] is ever populated, and it gives you the buffer size of each plane. - we do not need to recalculate anything upon putting frames into an AudioFrame, the buffer size does not change. - "align" is not a boolean, it can be any power of two. We stop carrying around "align", "nb_channels" and "nb_planes", they are not needed.
|
You'll notice that |
mikeboers
pushed a commit
that referenced
this pull request
Oct 9, 2018
This PR fixes several misunderstandings concerning AudioFrame buffer sizes: - for audio, "line size" and "buffer size" are equivalent, as there is only ever a single "line". - only linesizes[0] is ever populated, and it gives you the buffer size of each plane. - we do not need to recalculate anything upon putting frames into an AudioFrame, the buffer size does not change. - "align" is not a boolean, it can be any power of two. We stop carrying around "align", "nb_channels" and "nb_planes", they are not needed. Merges #421.
|
Cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several misunderstandings concerning AudioFrame buffer
sizes:
for audio, "line size" and "buffer size" are equivalent, as there is
only ever a single "line".
only linesizes[0] is ever populated, and it gives you the buffer size
of each plane.
we do not need to recalculate anything upon putting frames into an
AudioFrame, the buffer size does not change.
"align" is not a boolean, it can be any power of two.
We stop carrying around "align", "nb_channels" and "nb_planes", they are
not needed.