Allow building non-gpl ffmpeg #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the big picture here? Can you please spell out where we are heading before merging any more PRs? |
jlaine
reviewed
Nov 7, 2023
jlaine
reviewed
Nov 7, 2023
jlaine
reviewed
Nov 7, 2023
jlaine
reviewed
Nov 7, 2023
| dest_dir = args.destination | ||
| build_stage = None if args.stage is None else int(args.stage) - 1 | ||
| disable_gpl = args.disable_gpl | ||
| del args |
There was a problem hiding this comment.
This is very unusual for Python code, why the del?
There was a problem hiding this comment.
del is used to signify that args will not be used anymore
jlaine
reviewed
Nov 7, 2023
jlaine
reviewed
Nov 7, 2023
jlaine
reviewed
Nov 7, 2023
|
The point of this PR is to enable building ffmpeg with the LGPLv3 license instead of GPLv3 with a single flag. This allows forkers who want a more permissive ffmpeg build to only have to change 2 lines, not 80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.