Incrementing version to 0.8.0 and including py2 bz2 support #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your solution is fine. The best solution is to drop support for Python2.7 which has EOL 2020. ;-) It would save a great deal of baggage, while allowing the use of some very neat Python3.6+ features, such as f-strings |
|
That's interesting about the f-strings! Being a loyal Py2 user, I hadn't heard of them :). But you are right, Py2 is supposed to be phased out soon. Perhaps we should switch to Py2-only in v0.9 or v1.0. In the meanwhile, I'll open a new Issue where we can keep track of all of simplification that we can make when we switch to Py3 only. |
|
Alright, if there are no objections, I'll go ahead and merge and make the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm incrementing the version to 0.8.0, in anticipation of a new release (we closed all of the issues for v0.8, hurray!).
Also, I've changed the way that the
O2-ANU1024.txt.bz2file is loaded. I'm not too excited about how this makes the examples more complicated, but I'm not sure what the easier solution is. Perhaps we can just use a text file, but then the file becomes several MB. Alternatively, we could make the file a PNG, but then @stggh would need to accept some degradation of his beautiful image.Any other ideas?