Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixxed Quiz9 #72

Merged
merged 2 commits into from
May 24, 2021
Merged

Fixxed Quiz9 #72

merged 2 commits into from
May 24, 2021

Conversation

LeoCumpli21
Copy link
Collaborator

This PR:

  • Fixes quiz 9 exercises.
  • Enhances translation from Portuguese to Spanish.
  • Enhances instructions of the exercises.

Most of Quiz 9 was looking like this:
quiz9_ss

Fix exercises. 
Enhanced translation from Portuguese to Spanish.
Enhanced instructions of the exercises.
Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

El nombre de algunas funciones están en inglés y otras en castellano, quizás deberíamos normalizar y definir un único idioma.

@y-martinez
Copy link
Collaborator

Looks good to me!

El nombre de algunas funciones están en inglés y otras en castellano, quizás deberíamos normalizar y definir un único idioma.

@angelasofiaremolinagutierrez y @LeoCumpli21 habíamos coincidido que el Inglés debería ser el lenguaje del nombre de las funciones y así normalizar en todos los quices 😄 igualmente podemos conversarlo en la reunión de hoy

@reingart reingart closed this May 24, 2021
@reingart reingart reopened this May 24, 2021
@reingart reingart closed this May 24, 2021
@reingart reingart reopened this May 24, 2021
@github-actions
Copy link

_sources/quiz/Quiz9.rst Outdated Show resolved Hide resolved
@github-actions
Copy link

self.assertEqual(mayor_extremo([2, 11, 3]), [3, 3, 3],"Esperado: [3,3,3]")
self.assertEqual(mayor_extremo([11, 3, 3]), [11, 11, 11],"Esperado: [11,11,11]")
self.assertEqual(mayor_extremo([3, 11, 11]), [11, 11, 11],"Esperado: [11,11,11]")
self.assertEqual(mayor_extremo([2, 2, 2]), [2, 2, 2],"Esperado: [2,2,2]"")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.assertEqual(mayor_extremo([2, 2, 2]), [2, 2, 2],"Esperado: [2,2,2]"")
self.assertEqual(mayor_extremo([2, 2, 2]), [2, 2, 2],"Esperado: [2,2,2]")

@reingart
Copy link
Member

Ver Bug nuevo: #76

@reingart reingart merged commit 4064ce6 into PyAr:master May 24, 2021
reingart added a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants