Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a bound to the inference tips cache #1565

Merged
merged 3 commits into from
May 15, 2022
Merged

Add a bound to the inference tips cache #1565

merged 3 commits into from
May 15, 2022

Conversation

jacobtylerwalls
Copy link
Member

Description

Add a bound to the size of the inference tips cache.

I explored making this user-configurable, but I don't really see a compelling use case. It's also difficult because of the inaccessibility of manipulating the inference_tip module at runtime: inference_tip() is imported over the module name.

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

Closes #1150

@jacobtylerwalls jacobtylerwalls added this to the 2.12.0 milestone May 15, 2022
@coveralls
Copy link

coveralls commented May 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2328116809

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.831%
Totals Coverage Status
Change from base Build 2324683371: 0.003%
Covered Lines: 9195
Relevant Lines: 10013
💛 - Coveralls

@jacobtylerwalls jacobtylerwalls merged commit 95bbd5e into pylint-dev:main May 15, 2022
@jacobtylerwalls jacobtylerwalls deleted the maxsize-inference-tip-cache branch May 15, 2022 21:11
jacobtylerwalls added a commit to jacobtylerwalls/astroid that referenced this pull request May 15, 2022
@jacobtylerwalls
Add a bound to the inference tips cache (pylint-dev#1565)
e49f433
@cdce8p
Copy link
Member

cdce8p commented May 16, 2022

This PR causes a regression in Home Assistant

Error: homeassistant/components/daikin/config_flow.py:88:15: E0712:
    Catching an exception which doesn't inherit from Exception: HTTPForbidden (catching-non-exception)

Discovered in cdce8p/ha-core#11, with current pylint and astroid main.

@jacobtylerwalls
Copy link
Member Author

Thanks, I'll take a look.

jacobtylerwalls added a commit to jacobtylerwalls/astroid that referenced this pull request May 16, 2022
@jacobtylerwalls
Revert "Add a bound to the inference tips cache (pylint-dev#1565)"
c9f3396 
This reverts commit 95bbd5e.
jacobtylerwalls added a commit to jacobtylerwalls/astroid that referenced this pull request May 16, 2022
@jacobtylerwalls
Revert "Add a bound to the inference tips cache (pylint-dev#1565)"
ca0dab1 
This reverts commit 95bbd5e.
This was referenced May 16, 2022
Merged
Closed
cdce8p pushed a commit that referenced this pull request May 17, 2022
@jacobtylerwalls
Revert "Add a bound to the inference tips cache (#1565)" (#1570)
33b6c56 
This reverts commit 95bbd5e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
topic-performance
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Automatic cache clearing with lru_cache's maxsize
5 participants
@jacobtylerwalls @coveralls @cdce8p @Pierre-Sassoulas @DanielNoord