Fix misc type issues #1884
Merged
Fix misc type issues #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdrozd
commented
Nov 22, 2022
nickdrozd
commented
Nov 22, 2022
astroid/nodes/scoped_nodes/mixin.py
Outdated
| @@ -109,7 +109,7 @@ def _append_node(self, child: nodes.NodeNG) -> None: | |||
| # which uses the current class as a mixin or base class. | |||
| # It's rewritten in 2.0, so it makes no sense for now | |||
| # to spend development time on it. | |||
| self.body.append(child) | |||
| self.body.append(child) # type: ignore | |||
There was a problem hiding this comment.
Some dynamic trickery happening here. From comment: # pylint: disable=no-member; depending by the class
There was a problem hiding this comment.
We should at least ignore a specific warning instead of the broader ignore.
nickdrozd
commented
Nov 22, 2022
| @@ -75,5 +75,5 @@ def brainless_manager(): | |||
| m.astroid_cache = {} | |||
| m._mod_file_cache = {} | |||
| m._transform = transforms.TransformVisitor() | |||
| m.extension_package_whitelist = {} | |||
| m.extension_package_whitelist = set() | |||
There was a problem hiding this comment.
Straightforward type error
Pull Request Test Coverage Report for Build 3526908840
💛 - Coveralls |
nickdrozd
commented
Nov 22, 2022
| @@ -636,13 +636,14 @@ def _infer_old_style_string_formatting( | |||
| TODO: Instead of returning Uninferable we should rely | |||
| on the call to '%' to see if the result is actually uninferable. | |||
| """ | |||
| values = None | |||
There was a problem hiding this comment.
Rather than assign and then reassign with a different type, just make sure the variable gets defined in all branches
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
approved these changes
Nov 22, 2022
DanielNoord
requested changes
Nov 22, 2022
astroid/nodes/scoped_nodes/mixin.py
Outdated
| @@ -109,7 +109,7 @@ def _append_node(self, child: nodes.NodeNG) -> None: | |||
| # which uses the current class as a mixin or base class. | |||
| # It's rewritten in 2.0, so it makes no sense for now | |||
| # to spend development time on it. | |||
| self.body.append(child) | |||
| self.body.append(child) # type: ignore | |||
There was a problem hiding this comment.
We should at least ignore a specific warning instead of the broader ignore.
DanielNoord
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address some minor Mypy complaints.
Type of Changes