Reflect AST changes in Python 3.8. #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
ast-py38
branch
from
afc2751
to
59a3a7a
Compare
* Num, Str, Bytes, Ellipsis and NameConstant are replaced with Constant. (https://bugs.python.org/issue32892) * Index is replaced with its value, ExtSlice is replaced with Tuple. (https://bugs.python.org/issue34822)
serhiy-storchaka
force-pushed
the
ast-py38
branch
from
59a3a7a
to
fccd5a5
Compare
|
Thank you so much @serhiy-storchaka ! This is super useful. |
hadisfr
added a commit
to hadisfr/clara
that referenced
this pull request
Jul 14, 2020
due to deprecating `ast.Num`, `ast.Str`, `ast.Bytes`, `ast.Ellipsis` and `ast.NameConstant` in favour of `ast.Constant` in python3.8 ref: pylint-dev/astroid#616 ref: https://bugs.python.org/issue32892#msg342486
iradicek
pushed a commit
to iradicek/clara
that referenced
this pull request
Nov 11, 2020
* add more files to .gitignore * add clusters folder to .gitignore * add more description into "NotSupported: Unimplemented visitor" exception message * fix an issue with python3.8+ due to deprecating `ast.Num`, `ast.Str`, `ast.Bytes`, `ast.Ellipsis` and `ast.NameConstant` in favour of `ast.Constant` in python3.8 ref: pylint-dev/astroid#616 ref: https://bugs.python.org/issue32892#msg342486 * make .gitignore minimal ref #19 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
There will be several changes in AST in Python 3.8.
ast.Num,ast.Str,ast.Bytes,ast.Ellipsisandast.NameConstantare replaced withast.Constant.(https://bugs.python.org/issue32892)
ast.Constantcan be used since Python 3.6, it is just thatast.parse()didn't produce it.This PR adds a handler for
ast.ConstantinTreeRebuilder.Simplified AST for subscriptions.
ast.Indexis replaced with its value,ast.ExtSliceis replaced withast.Tuple.(https://bugs.python.org/issue34822)
This change is not merged yet.
Since the code like
a[(::1, 1:)]is invalid syntax, tuples should be handled specially inas_string()when used as indices in subscription. As side effect, a comma with a space instead of a just comma is now used for separating slices in theas_string()output.Type of Changes
Closes #617.