Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lazy-object-proxy >= 1.5.0 #801

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Allow lazy-object-proxy >= 1.5.0 #801

merged 1 commit into from
Dec 24, 2020

Conversation

priv-kweihmann
Copy link
Contributor

@priv-kweihmann priv-kweihmann commented Jun 10, 2020

by allowing every version >= 1.4.0

Fixes #800

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Allow lazy-object-proxy version >= 1.5.0

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

Closes #800

by allowing every version >= 1.4.0

Fixes #800

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Jun 19, 2020
@ViktorHaag
Copy link

If the purpose of the original pinning was to lower the risk of breaking changes in a dependency, would it not be better for this PR to pin to versions <2 for the dependency than admit for future, potentially breaking, versions?

@priv-kweihmann
Copy link
Contributor Author

Don't know, never heard anything back about the original reasoning of the version pinning.
And to be honest a breaking API change could happen with any version update (as nobody seems to care really about a proper versioning scheme) - so I personally think that setting a base version and accepting any version higher than that, is the way it should be done - as fixes for newer versions have to be done anyway (if not now than at some point in the future)

@priv-kweihmann
Copy link
Contributor Author

Any news of this item? Can I do something to get this merged?

@stonebig
Copy link

I would hope if you change it to "lazy_object_proxy>=1.4,<1.6" it may be accepted

@FelixMoelder
Copy link
Contributor

A merge would be nice, as lazy-object-proxy 1.4.x is not available on conda-forge for osx-arm64.

@efwahl
Copy link

efwahl commented Nov 30, 2020

The ==1.4.* pinning is breaking with other packages which have an explicit 1.5 requirement and the new pip resolver behavior. It would be nice to have a fix promptly.

@AadamZ5
Copy link

AadamZ5 commented Dec 4, 2020

I'm also running into issues with the ==1.4.* pinning having conflicts with other packages in my project. It seems like this PR would be fine to move in with >=1.5.0. The sooner the better 😊, and thank you for your help!

@PCManticore
Copy link
Contributor

Thanks for the PR.

@PCManticore PCManticore merged commit 744a9a8 into pylint-dev:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy-object-proxy update to 1.5.0 breaks astroid
7 participants