New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnicodeDecodeError when running pre-commit on Windows with v2.3.0
#294
Labels
Comments
Ugh I think that's because we're trying to decode |
fsouza
added a commit
that referenced
this issue
Mar 13, 2024
This should fix an issue on Window where the `setup.cfg` can contain non-ascii characters, and Python is trying to use cp1252. This should be safe as utf-8 is compatible with cp1252. It's possible I'll eat my words and some other platform breaks with this change, but let's try. Closes #294.
fsouza
added a commit
that referenced
this issue
Mar 13, 2024
This should fix an issue on Window where the `setup.cfg` can contain non-ascii characters, and Python is trying to use cp1252. This should be safe as utf-8 is compatible with cp1252. It's possible I'll eat my words and some other platform breaks with this change, but let's try. Closes #294.
fsouza
added a commit
that referenced
this issue
Mar 13, 2024
This should fix an issue on Window where the `setup.cfg` can contain non-ascii characters, and Python is trying to use cp1252. This should be safe as utf-8 is compatible with cp1252. It's possible I'll eat my words and some other platform breaks with this change, but let's try. Closes #294.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For now I'm just disabling the hook instead of trying to debug further (already tried with new environments).
The text was updated successfully, but these errors were encountered: