Fix code review

PyCQA · Jun 14, 2018 · 82f877b · 82f877b
1 parent d3f8164
commit 82f877b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/bandit/plugins/yaml_load.py b/bandit/plugins/yaml_load.py
@@ -55,9 +55,10 @@
 @test.test_id('B506')
 @test.checks('Call')
 def yaml_load(context):
-    if context.is_module_imported_exact('yaml') and \
-       isinstance(context.call_function_name_qual, str):
-        qualname_list = context.call_function_name_qual.split('.')
+    imported = context.is_module_imported_exact('yaml')
+    qualname = context.call_function_name_qual
+    if imported and isinstance(qualname, str):
+        qualname_list = qualname.split('.')
         func = qualname_list[-1]
         if 'yaml' in qualname_list and func == 'load':
             if not context.check_call_arg_value('Loader', 'SafeLoader'):

diff --git a/examples/yaml_lib_load.py b/examples/yaml_lib_load.py
diff --git a/tests/functional/test_functional.py b/tests/functional/test_functional.py
@@ -464,12 +464,6 @@ def test_yaml(self):
         }
         self.check_example('yaml_load.py', expect)
 
-        expect = {
-            'SEVERITY': {'UNDEFINED': 0, 'LOW': 0, 'MEDIUM': 0, 'HIGH': 0},
-            'CONFIDENCE': {'UNDEFINED': 0, 'LOW': 0, 'MEDIUM': 0, 'HIGH': 0}
-        }
-        self.check_example('yaml_lib_load.py', expect)
-
     def test_jinja2_templating(self):
         '''Test jinja templating for potential XSS bugs.'''
         expect = {