Django sql injection #292
Merged
Django sql injection #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, will let either @ericwb or @sigmavirus24 be approving reviews. |
sigmavirus24
approved these changes
May 16, 2018
ericwb
reviewed
May 16, 2018
|
|
||
|
|
||
| import ast | ||
| import bandit |
There was a problem hiding this comment.
Should be a blank line before this import. Pep8 says to group imports.
| - https://docs.djangoproject.com/en/dev/topics/ | ||
| security/#sql-injection-protection | ||
|
|
||
| .. versionadded:: X.X.X |
| - https://docs.djangoproject.com/en/dev/topics/ | ||
| security/#sql-injection-protection | ||
|
|
||
| .. versionadded:: X.X.X |
ericwb
reviewed
May 16, 2018
There was a problem hiding this comment.
Also need autodoc link to these new plugins. See https://github.com/PyCQA/bandit/tree/master/doc/source/plugins
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done issue #291