Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shell #298

Merged
merged 7 commits into from Jun 14, 2018
Merged

Improve shell #298

merged 7 commits into from Jun 14, 2018

Conversation

ehooo
Copy link
Contributor

@ehooo ehooo commented May 8, 2018

Done #157

@lukehinds lukehinds requested a review from ericwb May 9, 2018 08:37
ericwb
ericwb requested changes May 10, 2018
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Can you remove the issue reference please? Also, I'd like to wait for the functional testing in the build to be working prior to merging this. Unfortunately, test_functional isn't running yet.

examples/subprocess_shell.py Outdated
@@ -31,3 +34,21 @@ def Popen(*args, **kwargs):
subprocess.Popen(command, shell=True)

subprocess.Popen('/bin/ls && cat /etc/passwd', shell=True)

# Issue #157
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove references to bugs/issues. We can always use git or git blame to look up changes based on what issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lukehinds lukehinds self-requested a review May 16, 2018 06:50
lukehinds
lukehinds reviewed Jun 12, 2018
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericwb are your change recommendations satisfied now (if so, happy to merge)

ericwb
ericwb reviewed Jun 12, 2018
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good to go. Just had one question.

examples/subprocess_shell.py
@@ -5,6 +5,9 @@
def Popen(*args, **kwargs):
print('hi')

def __len__(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to this patch? Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any object with length 0 is False, I set this in the test because this will not be detected as False, so is a known false positive.

ericwb
ericwb approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge for now.

@ericwb ericwb merged commit baac2e2 into PyCQA:master Jun 14, 2018
@ericwb ericwb mentioned this pull request Jun 14, 2018
Closed
@ehooo ehooo deleted the improve_shell branch July 13, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds left review comments

@ericwb ericwb ericwb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehooo @ericwb @lukehinds