Logo design: Bandit #302
Merged
Logo design: Bandit #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sigmavirus24 are we ok with the MIT license embedded (I assume not, and personally see no issue). |
ericwb
reviewed
May 11, 2018
logo/license
Outdated
| @@ -0,0 +1,9 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
Bandit as a project has an Apache 2 license. Can you please change so we have a single license for all the source.
|
I changed license from mit to apache 2.0 , could you please check it? |
ericwb
requested changes
May 11, 2018
logo/license
Outdated
| @@ -0,0 +1,65 @@ | |||
| Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ | |||
There was a problem hiding this comment.
I don't think we need this file since we already have a LICENSE file that covers the entire project in the root path.
There was a problem hiding this comment.
I will remove it then
|
Fixes Issue #287 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I uploaded all necessary logo files (editable,monochrome,full-color).