Add experimental Python 3.8-dev to test with #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.2+ deprecated cgi.escape() for html.escape(). And in 3.8 cgi.escape() has been completely removed. This patch conditional makes use of html.escape() for 3.2 and higher. Fixes issue #338 Signed-off-by: Eric Brown <browne@vmware.com>
This patch adds the prerelease version of Python 3.8 to the testing. Although Bandit is unlikely to have compile errors with any future version, this step allows us to get a head start on any that may arise.
.travis.yml
Outdated
| @@ -25,6 +25,10 @@ matrix: | |||
| env: TOXENV=py37 | |||
| dist: xenial | |||
| sudo: true | |||
| - python: 3.8-dev | |||
| env: TOXENV=py | |||
There was a problem hiding this comment.
Yeah, I tried py38, but apparently tox doesn't yet support py38. But the docs do say by using "py" it will inherit a tox env for whatever Python interpreter is used.
https://tox.readthedocs.io/en/latest/example/basic.html#a-simple-tox-ini-default-environments
There was a problem hiding this comment.
I also opened an issue with tox: tox-dev/tox#912
ghugo
approved these changes
Aug 6, 2018
There was a problem hiding this comment.
Looks like [0] merged, this should be good.
[0] tox-dev/tox#913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the prerelease version of Python 3.8 to the testing.
Although Bandit is unlikely to have compile errors with any future
version, this step allows us to get a head start on any that may
arise.