Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more_info URL to XML output #354

Merged
merged 2 commits into from Aug 6, 2018
Merged

Add more_info URL to XML output #354

merged 2 commits into from Aug 6, 2018

Conversation

stannum-l
Copy link
Contributor

Outputting bandit report as XML does not put more_info URL while it
would if the output format is YAML or JSON. This patch set adds the
more_info URL to the XML display.

Signed-off-by: Tin Lam tin@irrational.io

@@ -27,7 +27,8 @@
<testsuite name="bandit" tests="1"><testcase
classname="examples/yaml_load.py" name="blacklist_calls"><error
message="Use of unsafe yaml load. Allows instantiation of arbitrary
objects. Consider yaml.safe_load().&#10;" type="MEDIUM">Test ID: B301
objects. Consider yaml.safe_load().&#10;" type="MEDIUM"
more_info="https://docs.openstack.org/developer/bandit/">Test ID: B301
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not have the more_info link example be to the openstack docs. The docs are now hosted on https://bandit.readthedocs.io/en/latest/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

Outputting bandit report as XML does not put `more_info` URL while it
would if the output format is YAML or JSON. This patch set adds the
`more_info` URL to the XML display.

Signed-off-by: Tin Lam <tin@irrational.io>
@ghugo
Copy link
Contributor

ghugo commented Aug 6, 2018

lgtm, will let eric approve as well

@ericwb ericwb merged commit 95fee78 into PyCQA:master Aug 6, 2018
@stannum-l stannum-l deleted the xml-link branch August 6, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants